Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESM #147

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Support ESM #147

wants to merge 1 commit into from

Conversation

reesericci
Copy link

Adds support for use as an ESM module with the following syntax:

import Filter from 'badwords'

@reesericci reesericci mentioned this pull request Apr 29, 2022
Closed
web-mech
web-mech requested changes Jan 5, 2023
View reviewed changes
Copy link
Owner

@web-mech web-mech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to support ESM here without needing to support both ESM + CJS. But this will need to be a part of a major release. We should also update the dependencies being required here.

@web-mech web-mech changed the base branch from master to next January 5, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-mech web-mech web-mech requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reesericci @web-mech