Remove testdriver from some StylableSelect WPTs

testdriver is not supported in reftests: #13183 #46152 I worked around using testdriver in some of these tests, but others really need to use testdriver so I put a comment in them saying that the test probably won't work until testdriver in reftests is supported. These tests are still worth keeping not only for future support but because they work properly when run with run_web_tests.py. Bug: 40146374 Change-Id: I73d02e5ead3c2dd4c84300e78f6502357dd7524b
web-platform-tests · May 13, 2024 · 226a372 · 226a372
1 parent e40e7e0
commit 226a372
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 38 deletions.
diff --git a/html/semantics/forms/the-select-element/stylable-select/native-popup-with-datalist-ref.html b/html/semantics/forms/the-select-element/stylable-select/native-popup-with-datalist-ref.html
@@ -11,6 +11,9 @@
 
 <script>
 (async () => {
+  // This test needs test_driver.bless() in order to get user activation for
+  // showPicker, but likely won't work properly until this bug is fixed:
+  // https://github.com/web-platform-tests/wpt/issues/13183
   await test_driver.click(document.querySelector('select'));
   document.documentElement.classList.remove('reftest-wait');
 })();

diff --git a/...antics/forms/the-select-element/stylable-select/native-popup-with-datalist.tentative.html b/...antics/forms/the-select-element/stylable-select/native-popup-with-datalist.tentative.html
@@ -19,6 +19,9 @@
 
 <script>
 (async () => {
+  // This test needs test_driver.bless() in order to get user activation for
+  // showPicker, but likely won't work properly until this bug is fixed:
+  // https://github.com/web-platform-tests/wpt/issues/13183
   await test_driver.click(document.querySelector('select'));
   document.documentElement.classList.remove('reftest-wait');
 })();

diff --git a/...select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html b/...select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html
@@ -14,6 +14,9 @@
 
 <script>
 (async () => {
+  // This test needs test_driver.bless() in order to get user activation for
+  // showPicker, but likely won't work properly until this bug is fixed:
+  // https://github.com/web-platform-tests/wpt/issues/13183
   await test_driver.bless();
   document.querySelector('select').showPicker();
   document.documentElement.classList.remove('reftest-wait');

diff --git a/...ntics/forms/the-select-element/stylable-select/select-appearance-dark-mode.tentative.html b/...ntics/forms/the-select-element/stylable-select/select-appearance-dark-mode.tentative.html
@@ -1,10 +1,7 @@
 <!DOCTYPE html>
-<html class=reftest-wait>
 <link rel=author href="mailto:jarhar@chromium.org">
 <link rel=help href="https://github.com/whatwg/html/issues/9799">
 <link rel=match href="select-appearance-dark-mode-ref.html">
-<script src="/resources/testdriver.js"></script>
-<script src="/resources/testdriver-vendor.js"></script>
 
 <style>
 :root {
@@ -13,14 +10,12 @@
 </style>
 
 <select style="appearance:base-select">
-  <option>one</option>
-  <option>two</option>
+  <datalist>
+    <option>one</option>
+    <option>two</option>
+  </datalist>
 </select>
 
 <script>
-(async () => {
-  await test_driver.bless();
-  document.querySelector('select').showPicker();
-  document.documentElement.classList.remove('reftest-wait');
-})();
+document.querySelector('datalist').showPopover();
 </script>
diff --git a/...select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html b/...select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html
@@ -1,10 +1,7 @@
 <!DOCTYPE html>
-<html class=reftest-wait>
 <link rel=author href="mailto:jarhar@chromium.org">
 <link rel=help href="https://github.com/whatwg/html/issues/9799">
 <link rel=match href="select-appearance-no-button-no-datalist-ref.html">
-<script src="/resources/testdriver.js"></script>
-<script src="/resources/testdriver-vendor.js"></script>
 
 <select style="appearance:base-select">
   <datalist>
@@ -14,9 +11,5 @@
 </select>
 
 <script>
-(async () => {
-  await test_driver.bless();
-  document.querySelector('select').showPicker();
-  document.documentElement.classList.remove('reftest-wait');
-})();
+document.querySelector('datalist').showPopover();
 </script>
diff --git a/...the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html b/...the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html
@@ -13,6 +13,9 @@
 
 <script>
 (async () => {
+  // This test needs test_driver.bless() in order to get user activation for
+  // showPicker, but likely won't work properly until this bug is fixed:
+  // https://github.com/web-platform-tests/wpt/issues/13183
   await test_driver.bless();
   document.querySelector('select').showPicker();
   document.documentElement.classList.remove('reftest-wait');

diff --git a/...-select-element/stylable-select/select-appearance-writing-mode-vertical-lr.tentative.html b/...-select-element/stylable-select/select-appearance-writing-mode-vertical-lr.tentative.html
@@ -1,10 +1,7 @@
 <!DOCTYPE html>
-<html class=reftest-wait>
 <link rel=author href="mailto:jarhar@chromium.org">
 <link rel=help href="https://github.com/whatwg/html/issues/9799">
 <link rel=match href="select-appearance-writing-mode-vertical-lr-ref.html">
-<script src="/resources/testdriver.js"></script>
-<script src="/resources/testdriver-vendor.js"></script>
 
 <style>
 html {
@@ -16,14 +13,12 @@
 </style>
 
 <select>
-  <option>one</option>
-  <option>two</option>
+  <datalist>
+    <option>one</option>
+    <option>two</option>
+  </datalist>
 </select>
 
 <script>
-(async () => {
-  await test_driver.bless();
-  document.querySelector('select').showPicker();
-  document.documentElement.classList.remove('reftest-wait');
-})();
+document.querySelector('datalist').showPopover();
 </script>
diff --git a/...-select-element/stylable-select/select-appearance-writing-mode-vertical-rl.tentative.html b/...-select-element/stylable-select/select-appearance-writing-mode-vertical-rl.tentative.html
@@ -1,10 +1,7 @@
 <!DOCTYPE html>
-<html class=reftest-wait>
 <link rel=author href="mailto:jarhar@chromium.org">
 <link rel=help href="https://github.com/whatwg/html/issues/9799">
 <link rel=match href="select-appearance-writing-mode-vertical-rl-ref.html">
-<script src="/resources/testdriver.js"></script>
-<script src="/resources/testdriver-vendor.js"></script>
 
 <style>
 html {
@@ -16,14 +13,12 @@
 </style>
 
 <select>
-  <option>one</option>
-  <option>two</option>
+  <datalist>
+    <option>one</option>
+    <option>two</option>
+  </datalist>
 </select>
 
 <script>
-(async () => {
-  await test_driver.bless();
-  document.querySelector('select').showPicker();
-  document.documentElement.classList.remove('reftest-wait');
-})();
+document.querySelector('datalist').showPopover();
 </script>