Skip to content

Commit

Permalink
Set null as the default value of deviceProperties in PointerEventInit
Browse files Browse the repository at this point in the history
Previously, the default for deviceProperties in PointerEventInit was
undefined; although in chromium a value was set using the default
constructor. This CL changes this behaviour such that the default value
for deviceProperties is null. The corresponding WPT is updated as well.

For further context, please see the discussion here:
w3c/pointerevents#495 (comment)

Bug: 330760871
Change-Id: I5becf25f76e8b8c4572a783bfba8c1c4f36f8a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526091
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1298623}
  • Loading branch information
sahirv authored and chromium-wpt-export-bot committed May 9, 2024
1 parent f65f536 commit abcaa8d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,6 @@
height: 100,
isPrimary: true,
});
CheckDeviceId(downEventEmptyProps, INVALID_UNIQUE_ID);
assert_equals(downEventEmptyProps.deviceProperties, null);
}, 'No deviceProperties in PointerEventInit');
</script>

0 comments on commit abcaa8d

Please sign in to comment.