Replace most .__proto__ with Object.getPrototypeOf()
#27394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
asutherland,
boggydigital,
caitp,
dirkschulze,
domenic and
ewilligers
wpt-pr-bot
requested review from
kenrussell,
kojiishi,
Manishearth,
mikewest,
mkruisselbrink,
nikosandronikos,
odinho,
reillyeon,
rniwa,
shallawa,
snuggs,
svgeesus,
TakayoshiKochi and
TimothyGu
foolip
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Looks good, thanks! @nayeemrmn are you OK with the suggested rewording?
html/semantics/embedded-content/the-img-element/Image-constructor.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-img-element/Image-constructor.html
Outdated
Show resolved
Hide resolved
…tor.html Co-authored-by: Philip Jägenstedt <philip@foolip.org>
…tor.html Co-authored-by: Philip Jägenstedt <philip@foolip.org>
wpt-pr-bot
requested review from
timvolodine,
wanderview,
wisniewskit,
zcorpan and
zqzhang
and removed request for
Manishearth,
nikosandronikos,
shallawa,
svgeesus and
TakayoshiKochi
|
Thanks @nayeemrmn! I didn't spot that you applied the suggestions 3 days ago, but I'll review and merge this now. |
foolip
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left out the ones where
.__proto__appeared to be the subject of the test.Ref: denoland/deno#4324. We hit this usage in Deno:
wpt/url/urlsearchparams-constructor.any.js
Line 32 in 1f6bc47