Resolve a slot element's directionality from the flattened tree #32108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 16, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3343556
branch
from
630cec1
to
47bb9f9
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3343556
branch
3 times, most recently
from
932348b
to
aea9e11
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3343556
branch
2 times, most recently
from
1dacbe0
to
565b3f7
Compare
This CL applies the new agreements for a <slot> element on the standards meeting[1][2]. - Resolve the slot element's directionality from the flattened tree - Apply one exception that the slot element's directionality should be the same as a shadow host's directionality if the slot element has a dir=auto attribute and has no slotted content. This CL adds the unit tests on blink and WPT tests will be added on [3]. [1] whatwg/html#7299 [2] whatwg/html#3699 (comment) [3] #29820 Bug: 1236384 Change-Id: I43ca7351fc4d65dd4f72fe4f9627ffa5382e5c20
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3343556
branch
from
565b3f7
to
f61da91
Compare
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL applies the new agreements for a <slot> element on the
standards meeting[1][2].
be the same as a shadow host's directionality if the slot element
has a dir=auto attribute and has no slotted content.
This CL adds the unit tests on blink and WPT tests will be added on [3].
[1] whatwg/html#7299
[2] whatwg/html#3699 (comment)
[3] #29820
Bug: 1236384
Change-Id: I43ca7351fc4d65dd4f72fe4f9627ffa5382e5c20
Reviewed-on: https://chromium-review.googlesource.com/3343556
WPT-Export-Revision: cec8ee092ba6e5b2efb580e28823a640d50b707e