Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebCryptoAPI: add default generated HMAC key length tests #36348

Merged
merged 1 commit into from Oct 25, 2022
Merged

WebCryptoAPI: add default generated HMAC key length tests #36348

merged 1 commit into from Oct 25, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Oct 8, 2022

This indirectly adds tests to successes_HMAC that ensure that when HmacKeyGenParams.length is unspecified it defaults to the hash algorithm's default block size.

Refs: nodejs/node#44917

Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thanks!

@twiss twiss merged commit 0042d42 into web-platform-tests:master Oct 25, 2022
@panva
Copy link
Contributor Author

panva commented Oct 25, 2022

@twiss thank you

@panva panva deleted the add-default-hmac-length-successes branch October 25, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants