[Gecko Bug 1759031] Let user-action-pseudo-classes-in-has.html rely on actions being completed.
#43122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 13, 2023
…mpleted. Previously, the test relied upon event listener to listen to related events: e.g. `mousedown` event on `Actions().pointerDown()`. However, as comments in whatwg/html#7578 indicate when `:active` matches does not seem to be interoperable across browsers with different inputs. Instead rely on the action sequence being completed, as done with a simliar test, `html/semantics/selectors/pseudo-classes/active-disabled.html`. Differential Revision: https://phabricator.services.mozilla.com/D193463 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1759031 gecko-commit: adc6a6f51dfa6facc44c1afe4bf3455c3bf32fad gecko-reviewers: emilio
moz-wptsync-bot
force-pushed
the
gecko/1759031
branch
from
56a8f33
to
d4efeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the test relied upon event listener to listen to related events:
e.g.
mousedownevent onActions().pointerDown(). However, as comments inwhatwg/html#7578 indicate when
:activematchesdoes not seem to be interoperable across browsers with different inputs.
Instead rely on the action sequence being completed, as done with a simliar
test,
html/semantics/selectors/pseudo-classes/active-disabled.html.Differential Revision: https://phabricator.services.mozilla.com/D193463
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1759031
gecko-commit: ab075d8118aecde5cf88872225b85effcfffbacb
gecko-reviewers: emilio