Reland "[fetch-later] Define new permissions policy deferred-fetch"
#46159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5524593
branch
3 times, most recently
from
bf0120a
to
508e02c
Compare
This is a reland of commit 193729386996ac0bd40dba0aa98b7f85ff7b94d1 The failed test from https://crbug.com/339120680 is removed by https://crrev.com/c/5524593/1..2 as the same behavior is already covered by `/fetch/fetch-later/permissions-policy/deferred-fetch-default-permissions-policy.tentative.https.window.js` more carefully. Original change's description: > [fetch-later] Define new permissions policy `deferred-fetch` > > 1-Pager: https://docs.google.com/document/d/1P70kdENIByy3qWabN5rUPmBVkkANNSOM_jZynLnqINY/edit > > This CL follows the [guide] to define a new permissions policy > `deferred-fetch`, which is used to gate the new `fetchLater()` API. > Relevant WPT are added in this CL, and the subsequent CL will further > use this policy to adjust the request quota. > > In this CL, `deferred-fetch` is not added to chrome://settings/content > page. And no permission prompt for it. > > - webappsec request: w3c/webappsec-permissions-policy#544 > - "deferred-fetch" usage in fetchLater draft spec: https://whatpr.org/fetch/1647.html#request-a-deferred-fetch > - "deferred-fetch" policy discussion: WICG/pending-beacon#87 (comment) > - FetchLater Explainer: https://github.com/WICG/pending-beacon/blob/main/docs/fetch-later-api.md > > > [guide]: https://chromium.googlesource.com/chromium/src/+/main/components/permissions/add_new_permission.md > > Bug: b:40276121,339120680 > Change-Id: I2db4dd7484610fefb50c463552155b220f13ac5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367481 > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: Thomas Nguyen <tungnh@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Ming-Ying Chung <mych@chromium.org> > Reviewed-by: Yoav Weiss (@Shopify) <yoavweiss@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1297320} Bug: b:40276121,339120680 Change-Id: I41e2f0980f5d72eb6c0687a82d96ad4a59f59936
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5524593
branch
from
508e02c
to
5de5b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit 193729386996ac0bd40dba0aa98b7f85ff7b94d1
The failed test from https://crbug.com/339120680 is removed by https://crrev.com/c/5524593/1..2 as the same behavior is already covered by
/fetch/fetch-later/permissions-policy/deferred-fetch-default-permissions-policy.tentative.https.window.jsmore carefully.Original change's description:
Bug: b:40276121,339120680
Change-Id: I41e2f0980f5d72eb6c0687a82d96ad4a59f59936
Reviewed-on: https://chromium-review.googlesource.com/5524593
WPT-Export-Revision: 16799b2a7ba3b583d8b824e11bf25a25426ae7b3