Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DatePickerInputWithoutModal.tsx #373

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update DatePickerInputWithoutModal.tsx #373

wants to merge 6 commits into from

Conversation

DwayneGit
Copy link

@DwayneGit DwayneGit commented Mar 3, 2024 •
edited

  • Moved extra constraint that hid the HelperText completely unless there was an error into its own option showHelperTextOnError
  • rRoot styling on the DatePickerInputWithoutModal caused the container to fill space. with no way to reduce it
    See This issue:
    Can't set DatePickerInput height when used inside Modal. #186
  • Update Docs with new showHelperTextOnError flag and missing withModal flag

@DwayneGit
Update DatePickerInputWithoutModal.tsx
75bec56 
remove extra hideValidation constraint and root styling that caused container to fill space.
@DwayneGit
Update DatePickerInputWithoutModal.tsx
0de78b8 
add an option to hide HelperText completely unless there is an error
@DwayneGit
Update DatePickerInput.shared.tsx
d6f3f3c 
add showHelperTextOnError to props
@DwayneGit
Update input-date-picker.md
2685c93 
update docs with new flag and missing withModal option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iM-GeeKy iM-GeeKy iM-GeeKy left review comments

@RichardLindhout RichardLindhout Awaiting requested review from RichardLindhout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DwayneGit @iM-GeeKy @RichardLindhout