Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed vk-save connector #4651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gasievt
Copy link
Contributor

@gasievt gasievt commented Apr 17, 2024

Fixed vk-save connector
vk-save changed their name and url to kissvk.me so the connector stopped working

Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seem legit aside the one comment around the ID change as we use this for configuration changes for the connector so that will be lost even though the connector is technically the same.

We should probably generate GUID's for these

label: 'kissvk',
matches: ['*://*.kissvk.me/*'],
js: 'kissvk.js',
id: 'kissvk',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yayuyokitano should this be changed if the site is technically the same? Won't it mean any config will be lost?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inverse Hello. They changed their url and name back to vk-save.com. Should I close the pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the ID would mean any manual changes etc under the old site would be lost. let wait to see what others suggest...

@inverse inverse added patch-change For patch changes fixed-connector for PRs that fix a connector labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-connector for PRs that fix a connector patch-change For patch changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants