fix: "ERR_INVALID_THIS" on Node 20 #86
Conversation
There was a problem hiding this comment.
Please note that formatting and other inconsistencies in the fetch sub-package were due to it been forked from node-fetch that used particular style. I thought it would be easier to pull upstream changes this way.
That said I have not really pulled any changes from node-fetch so perhaps that decision is worth revisiting. Given you've put more time into this than myself, you should make call what makes more sense going forward. I have no objections either way
|
@MichaelDeBoey looks like this breaks some tests, could you please fix them before landing this ? |
| @@ -138,7 +138,7 @@ export default class Headers extends URLSearchParams { | |||
| validateHeaderName(name); | |||
| // @ts-ignore | |||
| return URLSearchParams.prototype[p].call( | |||
| receiver, | |||
| target, | |||
| String(name).toLowerCase() | |||
There was a problem hiding this comment.
Looks like this introduces a regression in tests see https://github.com/web-std/io/actions/runs/5986735537/job/16286188008?pr=86
There was a problem hiding this comment.
@mcansh Any idea what this could have caused?
There was a problem hiding this comment.
narrowed it down to internal version mismatches between packages so installing/building the packages weren't using the latest changes
edit: tested with pnpm and workspace:* the packages together
There was a problem hiding this comment.
MichaelDeBoey
force-pushed
the
node-20
branch
2 times, most recently
from
26f3294
to
a5a297b
Compare
MichaelDeBoey
force-pushed
the
node-20
branch
2 times, most recently
from
9c7b1db
to
126988a
Compare
* fix: node 20 pnpm/node-fetch#1 Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: test against more node versions Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: update action versions Signed-off-by: Logan McAnsh <logan@mcan.sh> * chore: remove nested .github dir Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: disable fail fast Signed-off-by: Logan McAnsh <logan@mcan.sh> * ci: new server per test Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: update family agent option test Signed-off-by: Logan McAnsh <logan@mcan.sh> * Create polite-eggs-jam.md * test: use ipv4 Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: use family 0 Signed-off-by: Logan McAnsh <logan@mcan.sh> --------- Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
See @mcansh's remix-run#32
CC/ @alanshaw @Gozala