Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering issue on website impacting performance #1953

Open
1 task
JeffLowe opened this issue Sep 26, 2022 · 2 comments · May be fixed by #2115
Open
1 task

Fix rendering issue on website impacting performance #1953

JeffLowe opened this issue Sep 26, 2022 · 2 comments · May be fixed by #2115
Assignees
@e-schneid
Labels
kind/bug A bug in existing code (including security flaws) pi/dotstorage-site-improvements Improvements to web3 and nft websites stack/website

Comments

@JeffLowe
Copy link

JeffLowe commented Sep 26, 2022 •
edited

  • page by page remove the json rendering approach from legacy code.

(feel free to release fixes on page by page basis to keep steady progress flowing)

Overview

Something appears to be making the browser repaint the entire window when i scroll, which gives the site an unstable feeling.

This is caused at least in part by how the pages were implemented using JSON rendering. Need to refactor to remove this rendering issue.

This is apparent in blog and in web3.storage website. This ticket is for the web3 website.
https://github.com/web3-storage/web3.storage-content/issues/50 addresses the refactoring / fixing needed on the blog.

Results from quick device testing on 9.27.22

  • Not as noticeable on iphone 8 ios 15.6.1 Safari (actually, barely perceptable)
  • Same device( iphone 8 ios 15.6.1), Chrome browser more noticeable.
  • Pixel6 Chrome latest, probably the most noticeable.
  • Pixel 6 firefox, I cannot see an issue
  • Desktop macos 12.6 Chrome latest, I see the issue on web3 website when I scroll quickly.
  • Desktop macos 12.6 Safari, the web3 website repainting issue very noticeable while scrolling.
@JeffLowe JeffLowe added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization pi/dotstorage-site-improvements Improvements to web3 and nft websites labels Sep 26, 2022
@JeffLowe
Copy link
Author

One cause is likely the json rendering. Will need to factor that out from legacy code.

@JeffLowe JeffLowe changed the title Possible Repainting issue on website impacting performance Fix rendering issue on website impacting performance Sep 30, 2022
@JeffLowe JeffLowe mentioned this issue Sep 30, 2022
Open
@JeffLowe JeffLowe assigned e-schneid and unassigned johnathonroach Oct 5, 2022
@JeffLowe
Copy link
Author

JeffLowe commented Oct 5, 2022

@e-schneid reference related fix on blog https://github.com/web3-storage/web3.storage-content/pull/56 & https://github.com/web3-storage/web3.storage-content/pull/48

@JeffLowe JeffLowe mentioned this issue Oct 5, 2022
Closed
@e-schneid e-schneid linked a pull request Nov 18, 2022 that will close this issue
Open
@e-schneid e-schneid linked a pull request Nov 18, 2022 that will close this issue
fix: begin refactoring away from json content files #2115
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-schneid e-schneid

Labels
kind/bug A bug in existing code (including security flaws) pi/dotstorage-site-improvements Improvements to web3 and nft websites stack/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: begin refactoring away from json content files web3-storage/web3.storage
3 participants
@johnathonroach @JeffLowe @e-schneid