fix: begin refactoring away from json content files #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
e-schneid
commented
Nov 21, 2022
| * | ||
| * @returns | ||
| */ | ||
| export function Sectionals({ children, variant, id }) { |
There was a problem hiding this comment.
The existing code used the name "sectionals," and then each of these contained a number of "sectional" components, and within "sectional" you'll find "column." The naming needs a little help, I think, and I'm open to ideas. Maybe "Container" for the outermost box, then "Section," and then "Column"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket
This is an initial pass to begin removing the json content files (and BlockBuilder, etc) in favor of more standard React, to make it a bit easier for developers to make changes and also hopefully improve performance.
To facilitate smaller components, this also creates a new
page-componentsdirectory to keep components that are specifically for use on a given route (in Next.js we don't want to these files living under/pages).