Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundlesize to CI #3260

Merged
merged 5 commits into from
Dec 10, 2019
Merged

Add bundlesize to CI #3260

merged 5 commits into from
Dec 10, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Dec 7, 2019

Description

Adds a bundlesize checker to CI. First stage of plan for the build pipeline per comment 3160.

Service and tool lgtm, they have grant funding from Google Chrome. Added their token in CI to the Travis settings.

There are various config options including the ability to inspect multiple bundles, with and without compression. Chose a single report for the packages/web3/dist (uncompressed) because that seemed to give the clearest report. And set the maxSize high for now - can be tightened as size is optimized.

Looks like this:

Screen Shot 2019-12-07 at 1 12 08 PM

@nivida if you look in the CI build job you'll see a server error from buildsize - it's possible this is because you'll need to authorize the app for Web3? Currently just using a token from my auth.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Dec 7, 2019

Coverage Status

Coverage remained the same at 84.802% when pulling f0f9ffc on ci/add-buildsize-checker into 8804708 on 1.x.

@cgewecke cgewecke added the Review Needed Maintainer(s) need to review label Dec 8, 2019
@cgewecke cgewecke requested a review from nivida December 8, 2019 21:31
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great tool you found! LGTM! I've only added two comments about the execution of bundlesize.

scripts/ci.sh Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@nivida nivida added 1.x 1.0 related issues CI Enhancement Includes improvements or optimizations labels Dec 9, 2019
scripts/ci.sh Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/ci.sh Outdated Show resolved Hide resolved
@nivida nivida removed the Review Needed Maintainer(s) need to review label Dec 10, 2019
@nivida nivida merged commit 3922046 into 1.x Dec 10, 2019
@nivida nivida deleted the ci/add-buildsize-checker branch December 12, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants