Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: self-contained and improved ssi dive log tool #168

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

webbertakken
Copy link
Owner

@webbertakken webbertakken commented Apr 14, 2024

Changes

  • The QR code API that I was using no longer worked. It suddenly stopped functioning. Got an email from one of the people using the Garmin to SSI divelog helper tool that it was no longer functional.
  • Replaced external API by an in-page image generator that can no longer suddenly break.
  • Added a few images to show how the process works
  • Added a few words about users also being able to upload .zip files containing .fit files directly
  • The parsing happens so fast that sometimes it can be hard to see whether you successfully moved away from the previous dive onto the next. This is now fixed using a toast message, that will show when the QR code changes.
  • Made it a tad more mobile friendly

image

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

pr-code-reviewer bot commented Apr 14, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
takken-io ✅ Ready (Inspect) Visit Preview Apr 14, 2024 8:48pm

@webbertakken webbertakken merged commit 8bf8540 into main Apr 14, 2024
3 checks passed
@webbertakken webbertakken deleted the fix-qr-code branch April 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant