Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redirection bug #123

Closed
wants to merge 10 commits into from
Closed

fix redirection bug #123

wants to merge 10 commits into from

Conversation

cherylli
Copy link
Contributor

@cherylli cherylli commented Feb 24, 2023

Summary

closes #107

Fix a bug with redirection where http:// will be replaced by http// (without colon)
This was due to adding // in front of the redirection url //${originalUrl} so it would redirect as an absolute path instead of a relative path.

The fix removes http or https in front of the url and redirect using that url

Checklist

  • fixed the redirection bug
  • tested locally.
  • No error nor warning in the console.

@cherylli cherylli self-assigned this Feb 24, 2023
@cherylli
Copy link
Contributor Author

cherylli commented Feb 24, 2023

cypress tests seems to be broken on github (nothing changed in the workflow file since 3 months ago) tests work fine locally

possibly this: cypress-io/github-action#802

CypressError: `cy.visit()` failed trying to load:

http://localhost:5173/

We attempted to make an http request to this URL but the request failed without a response.

We received this error at the network level:

  > Error: connect ECONNREFUSED 127.0.0.1:5173

image

@cherylli cherylli mentioned this pull request Mar 14, 2023
@cherylli cherylli closed this Mar 14, 2023
@cherylli
Copy link
Contributor Author

#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: url redirection with http://
1 participant