Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Adding support for custom interfaces #125

Closed

Conversation

dstgermain
Copy link

#33

@jsf-clabot
Copy link

jsf-clabot commented Jan 19, 2018

CLA assistant check
All committers have signed the CLA.

@dstgermain
Copy link
Author

Hey guys, saw the issue. I'm actually in need of this functionality to add locale based skips to the interface. Let me know your thoughts on this.

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this?

@dstgermain
Copy link
Author

Sure, no problem.

@dstgermain
Copy link
Author

Added some tests, one just mimics another test that uses the default ui to check to make sure the hooks still work. And another checks to make sure the ui loaded into the global. Let me know if there's anything else.

@dstgermain
Copy link
Author

Haven't heard from anyone in awhile on this. We ended up using something else.

@dstgermain dstgermain closed this May 21, 2018
@dstgermain dstgermain deleted the customInterface branch May 21, 2018 14:24
@Matthematic
Copy link

@dstgermain what else did you use? This functionality would be very useful so I'm surprised it was abandoned.

@dstgermain
Copy link
Author

@Matthematic - We ended up forking it. Then we ended up rewriting webdriver.io with async awaits and less restrictions. It ended up being a very light library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants