Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Get true parentUID for suite #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Get true parentUID for suite #68

wants to merge 1 commit into from

Conversation

lisss
Copy link

@lisss lisss commented Jun 30, 2017

No description provided.

@lisss
Copy link
Author

lisss commented Jun 30, 2017

@christian-bromann Could you please check this PR? I've made this change because do need a unique parentUid in suite events (without this, I could only get the parent title but it might me non0unuque across the tests project)

@lisss
Copy link
Author

lisss commented Jul 4, 2017

@christian-bromann Any updates on this?

@christian-bromann
Copy link
Contributor

Will look into it this weekend. Thanks!

@lisss
Copy link
Author

lisss commented Jul 13, 2017

@christian-bromann Have you got any chance to look at it?

@christian-bromann
Copy link
Contributor

@lisss sorry for getting back to you so late. Can you demonstrate the issue based on an example project? What is exactly the issue this patch is fixing?

@lisss
Copy link
Author

lisss commented Nov 16, 2017

@christian-bromann Sure, I can.
So, assume there is a tree of suites like this:

Document toolbar
    |__ Share dropdown

When I receive suite:start and suite:endevents with my child suite details, I expect its parent UID to be UID of a parent suite not its own UID. But got this:

{ 
  type: 'suite:start',
  title: 'Share dropdown',
  parent: 'Document toolbar',
  fullTitle: 'Document toolbar Share dropdown',
  ...
  uid: 'Share dropdown6',
  parentUid: 'Share dropdown6',
  ...
}

(make a note of the uid and parentUid properties)
We implement our custom reporter and want to store suites structure, and this issue does'n allow us to be completely sure we pick up correct parent suite (we cannot rely on the title as it may not be unique across the project)

@ghost
Copy link

ghost commented Apr 3, 2019

Heyyy, 2 years later... But can we take a look at this again? We're running into the same problem while creating a custom reporter. Would be super helpful.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants