This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
stash #59
Open
stash #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pmerwin
commented
Dec 21, 2018
There was a problem hiding this comment.
․TypeError: Cannot read property 'mochaOpts' of undefined
at SauceService.after (/Users/pmerwin/Projects/qa/NWDIO/lib-webdriverio-nodejs/node_modules/wdio-sauce-service/build/sauce-service.js:132:34)
at execHook (/Users/pmerwin/Projects/qa/NWDIO/lib-webdriverio-nodejs/node_modules/wdio-sync/build/index.js:162:35)
so far changes are failing
| failures = 1 | ||
| } | ||
|
|
||
| // const status = 'status: ' + (failures > 0 ? 'failing' : 'passing') |
There was a problem hiding this comment.
Not sure what do about the logging methods as that was not previously done here in this service it looks like?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to port webdriverio/webdriverio@a6ff45a back to v4, not sure what to do about the logger methods as the old service was not using that? Also getting an undefined error
․TypeError: Cannot read property 'mochaOpts' of undefined
at SauceService.after (/Users/pmerwin/Projects/qa/NWDIO/lib-webdriverio-nodejs/node_modules/wdio-sauce-service/build/sauce-service.js:132:34)
at execHook (/Users/pmerwin/Projects/qa/NWDIO/lib-webdriverio-nodejs/node_modules/wdio-sync/build/index.js:162:35)