Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): session utility #521

Merged
merged 44 commits into from May 2, 2024
Merged

(feat): session utility #521

merged 44 commits into from May 2, 2024

Conversation

goosewobbler
Copy link
Contributor

@goosewobbler goosewobbler commented Apr 9, 2024 •
edited

Building out the standalone feature proposed in #412.

TODO:

  • Fix mac error
  • Ensure it works with CJS
  • Check orphan window behaviour without app.quit on Linux & Windows
  • Fix windows EB error on CI
  • Units
  • Clean up
  • Docs
  • Fix windows E2E timeouts

@goosewobbler goosewobbler added the WIP Work in progress label Apr 9, 2024
@goosewobbler goosewobbler force-pushed the sm/standalone-utility branch 2 times, most recently from 86a88ee to ac7457f Compare April 9, 2024 12:27
@goosewobbler goosewobbler force-pushed the sm/standalone-utility branch 2 times, most recently from 4db8dba to c86ef82 Compare April 9, 2024 13:55
@goosewobbler goosewobbler force-pushed the sm/standalone-utility branch 8 times, most recently from f90d032 to faba6b4 Compare April 9, 2024 15:44
@goosewobbler goosewobbler linked an issue Apr 9, 2024 that may be closed by this pull request
Provide utility function to allow using this service without the testrunner #412
Closed
@goosewobbler goosewobbler force-pushed the sm/standalone-utility branch 3 times, most recently from b5bcc29 to e72a6e2 Compare May 1, 2024 17:29
@goosewobbler goosewobbler marked this pull request as ready for review May 2, 2024 00:04
@goosewobbler goosewobbler force-pushed the sm/standalone-utility branch 2 times, most recently from ef76f38 to 185f226 Compare May 2, 2024 01:48
@goosewobbler goosewobbler removed the WIP Work in progress label May 2, 2024
christian-bromann
christian-bromann reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Great work! One question on how to end a session as well as an opportunity to automate pipeline updates.

.github/workflows/release.yml Show resolved Hide resolved
example-cjs/e2e-standalone/api.spec.ts Outdated Show resolved Hide resolved
christian-bromann
christian-bromann approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@goosewobbler goosewobbler merged commit a2cb203 into main May 2, 2024
4 checks passed
@goosewobbler goosewobbler deleted the sm/standalone-utility branch May 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.x.y
Development

Successfully merging this pull request may close these issues.

Provide utility function to allow using this service without the testrunner
2 participants
@goosewobbler @christian-bromann