Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Puppeteer Custom Engine support #36

Merged
merged 4 commits into from Aug 11, 2020
Merged

Conversation

Georgegriff
Copy link
Contributor

@Georgegriff Georgegriff commented Jul 19, 2020

@LarsDenBakker
Copy link

@Georgegriff any plans to release this as an experimental option? I copied the changes manually now :)

One suggestion regarding the name, I think something like deep or pierce-shadow would be a bit more descriptive.

@Georgegriff
Copy link
Contributor Author

Georgegriff commented Aug 4, 2020

I was waiting for it to land in stable puppeteer but I'm open to shipping a version the experience apis.

Yeah the name is tricky,. But the way this is currently implemented the user is complete free to decide on the name instead of shadow. Since the consumer is the one who registers the handler, my library just exposes the queryhandler implementation

@LarsDenBakker
Copy link

I'm not sure how long puppeteer plans to have this be experimental, but I think it would be great to offer this option in the meantime. I need it for a project myself, but we should promote this library more in general!

@Georgegriff Georgegriff marked this pull request as ready for review August 11, 2020 16:36
@Georgegriff Georgegriff merged commit 8cb2896 into master Aug 11, 2020
@Georgegriff Georgegriff deleted the puppeteer branch August 11, 2020 16:36
@Georgegriff
Copy link
Contributor Author

Released under 0.6.1 as experimental feature https://github.com/Georgegriff/query-selector-shadow-dom/releases/tag/0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants