Fix types for services (#5337)

webdriverio · Apr 29, 2020 · 96875b3 · 96875b3
1 parent c5ee329
commit 96875b3
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/scripts/templates/webdriverio.tpl.d.ts b/scripts/templates/webdriverio.tpl.d.ts
@@ -43,7 +43,7 @@ declare namespace WebdriverIO {
         [key: string]: any;
     }
     interface ServiceWithOption extends Array<string|ServiceOption>{ 0: string; 1: ServiceOption }
-    type ServiceEntry = string | HookFunctions | [string, ServiceOption]
+    type ServiceEntry = string | HookFunctions | [string, ServiceOption] | object
 
     interface Options {
         /**

diff --git a/tests/typings/sync/config.ts b/tests/typings/sync/config.ts
@@ -1,3 +1,9 @@
+class CustomService {
+  onPrepare() {
+      // TODO: something before all workers launch
+  }
+}
+
 const conf: WebdriverIO.Config = {
     // can be both array and function
     onComplete: (config, caps) => { },
@@ -18,6 +24,9 @@ const conf: WebdriverIO.Config = {
                 spawnCb: () => {}
             },
             skipSeleniumInstall: true
+        }],
+        [CustomService, {
+            someOption: true
         }]
     ],
 

diff --git a/tests/typings/webdriverio/config.ts b/tests/typings/webdriverio/config.ts
@@ -1,3 +1,9 @@
+class CustomService {
+  onPrepare() {
+      // TODO: something before all workers launch
+  }
+}
+
 const config: WebdriverIO.Config = {
     services: [
         ['selenium-standalone', {
@@ -9,6 +15,9 @@ const config: WebdriverIO.Config = {
                 basePath: ''
             },
             skipSeleniumInstall: true
+        }],
+        [CustomService, {
+            someOption: true
         }]
     ],