Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api for appium image comparison features #5372

Closed
sanlengjingvv opened this issue May 7, 2020 · 1 comment · Fixed by #5377
Closed

Add api for appium image comparison features #5372

sanlengjingvv opened this issue May 7, 2020 · 1 comment · Fixed by #5377
Labels
first-timers-only Issues that are well described and directed for people that start contributing to the project good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested

Comments

@sanlengjingvv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'm trying use appium's image comparison function via this document:
https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/image-comparison.md
but can't find api for this.

Describe the solution you'd like
Maybe a new api like browser.compare_images(mode, firstImage, secondImage, {options})
@sanlengjingvv sanlengjingvv changed the title Add api for Appium image comparison features Add api for appium image comparison features May 7, 2020
@christian-bromann christian-bromann added first-timers-only Issues that are well described and directed for people that start contributing to the project good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested labels May 7, 2020
@christian-bromann
Copy link
Member

According to Appiums Base Driver the command is defined under the route [POST] /session/$sessionId/appium/compare_images. This feature can be easily added by adding it to the Appium protocol definition in the @wdio/protocols package.

This is a fairly easy change and a great chance for someone making his first contribution to WebdriverIO.

sanlengjingvv added a commit to sanlengjingvv/webdriverio that referenced this issue May 8, 2020
@sanlengjingvv
wdio-protocolse: add api for appium image comparison features (webdri…
7cbd3f8 
…verio#5372)
@sanlengjingvv sanlengjingvv mentioned this issue May 8, 2020
Merged
8 tasks
christian-bromann pushed a commit that referenced this issue May 8, 2020
@sanlengjingvv
wdio-protocolse: add api for appium image comparison features (#5372) (…
c89756a 
…#5377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only Issues that are well described and directed for people that start contributing to the project good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wdio-protocolse: add api for appium image comparison features (#5372) sanlengjingvv/webdriverio
2 participants
@christian-bromann @sanlengjingvv