Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wdio-protocolse: add api for appium image comparison features (#5372) #5377

Merged
merged 1 commit into from May 8, 2020
Merged

wdio-protocolse: add api for appium image comparison features (#5372) #5377

merged 1 commit into from May 8, 2020

Conversation

sanlengjingvv
Copy link
Contributor

@sanlengjingvv sanlengjingvv commented May 8, 2020 •
edited by christian-bromann

Proposed changes

closes #5372

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@jsf-clabot
Copy link

jsf-clabot commented May 8, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@sanlengjingvv sanlengjingvv reopened this May 8, 2020
christian-bromann
christian-bromann approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome, LGTM!

@christian-bromann christian-bromann added the PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs label May 8, 2020
@christian-bromann christian-bromann merged commit c89756a into webdriverio:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add api for appium image comparison features
3 participants
@sanlengjingvv @jsf-clabot @christian-bromann