Fix tests in v7 #10604
Merged
Fix tests in v7 #10604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bull still the windows tests are failing at deep selectors. Wasn't able to find the cause of this. Tried to reproduce this with a test, but that was failing with invalid selector @christian-bromann can you help in fixing that windows test that is failing? |
README.md
Outdated
| @@ -7,7 +7,7 @@ | |||
| </p> | |||
|
|
|||
| <p align="center"> | |||
| Next-gen browser and mobile automation test framework for Node.js. | |||
| Next-gen browser and mobile automation test work for Node.js. | |||
There was a problem hiding this comment.
this was just to make some PR. forgot to remove. removed
The Windows tests have been failing for a bit longer and I am inclined to just ignore it. |
|
@christian-bromann In that case does that failing windows test will be a blocker for release? |
|
Windows tests passed. Don't know how 😆 |
Seems like they are just flaky |
christian-bromann
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
@types/nodeversions installed in different packagespackage-lock.jsonhas of version of v2, but npm 6 only supports v1. So maybe that's why upgrading it solved the issue. Also tried deleting the existing package-lock.json and runningnpm installwith npm 6, but that didn't solve the issue.setup-nodedoesn't offer any way to specify npm version, so had to upgrade it using command - related issuearia-querywas getting installed as 5.1.3 on linux and windows as 5.2.1 on Mac (mac be due to caching or something). The output of roleElements was different in different versions, thereby causing the tests to fail.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers