Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@wdio/lighthouse-service): migrate over from devtools service #12106

Closed
wants to merge 6 commits into from

Conversation

christian-bromann
Copy link
Member

Proposed changes

implements #11861

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

work in progress

Reviewers: @webdriverio/project-committers

erwinheitzman and others added 6 commits January 28, 2024 10:21
* (internal): drop support for Node.js 16

update engines of package.json files

* (internal): drop support for Node.js 16

update CONTRIBUTING.md with Node.js 20 as recommendation

* (internal): drop support for Node.js 16

update github workflows

* (internal): drop support for Node.js 16

update external packages that dropped the support already

* (internal): drop support for Node.js 16

resolve PR feedback

* Update packages/webdriver/package.json

* Update packages/wdio-cucumber-framework/package.json

* Update package.json

---------

Co-authored-by: Christian Bromann <git@bromann.dev>
* (webdriverio): merge isDisplayed and isDisplayedWithinViewport

* allow to specify withinViewport check in waitForDisplayed
fix type issues

fix unit tests
@christian-bromann
Copy link
Member Author

I will re-do this PR.

@christian-bromann christian-bromann deleted the cb/lighthouse-service branch February 17, 2024 03:17
@christian-bromann
Copy link
Member Author

see #12300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants