Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BoilerplateProjects.md #5348

Merged
merged 2 commits into from May 2, 2020

Conversation

SimitTomar
Copy link
Contributor

Hi Team,

Have created a boilerplate for webdriverio & cucumberjs, based on Page Object Model along with some other useful features. Kindly accept the changes.

Thanks
Simit

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Hi Team,

Have created a boilerplate for webdriverio & cucumberjs, based on Page Object Model along with some other useful features. Kindly accept the changes.

Thanks
Simit
@jsf-clabot
Copy link

jsf-clabot commented May 2, 2020

CLA assistant check
All committers have signed the CLA.

@SimitTomar
Copy link
Contributor Author

Signed the CLA :)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimitTomar thanks for creating an boilerplate project. Would you mind move this boilerplates to the bottom of the list? I would like to keep ones build by the WebdriverIO team at the top.

Hi Christian, have Moved the webdriverio-cucumber-pom-boilerplate to the bottom of the V6 boilerplates list.
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 89851eb into webdriverio:master May 2, 2020
@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 2, 2020
@christian-bromann
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants