Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint for modifiyng clicks #5349

Merged
merged 2 commits into from May 2, 2020
Merged

Conversation

ArminBu
Copy link
Contributor

@ArminBu ArminBu commented May 2, 2020

#5340 (comment)

Proposed changes

Add a hint to the documentation of keys.js about modifying clicks, as there is misleading information about it on StackOverflow (here and [here] (https://stackoverflow.com/questions/30077667/how-to-simulate-ctrl-click-or-shift-click-with-webdriver-io)) and people could save time, facing the same issue.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further Comments

I will also comment on linked SO Questions, that v6 is different.

Reviewers: @webdriverio/project-committers

@jsf-clabot
Copy link

jsf-clabot commented May 2, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 2, 2020
@christian-bromann
Copy link
Member

Congratulations on your first WebdriverIO contribution! This project can't live without the participation of the community. We appreciate you 🙏 ❤️

@christian-bromann christian-bromann merged commit 185dffc into webdriverio:master May 2, 2020
@ArminBu ArminBu deleted the patch-1 branch May 5, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants