devtools package: fix switchToFrame function #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add switchToFrame(number) test * add switchToFram(null) test (currently skipping) * fix switchToFrame(number ) to apply appropriate this value
* fix condition checking order to to avoid reference null value * fix val to avoid infinite loop
|
|
| @@ -32,7 +44,7 @@ export default async function switchToFrame ({ id }) { | |||
| * `page` has `frames` method while `frame` has `childFrames` method | |||
| */ | |||
| let getFrames = page.frames || page.childFrames | |||
| const childFrames = await getFrames() | |||
| const childFrames = await getFrames.apply(page) | |||
There was a problem hiding this comment.
Why not do getFrames(page)?
There was a problem hiding this comment.
The method doesn't take arguments. @takeya0x86 is correct here we call the method without its scope.
christian-bromann
approved these changes
May 6, 2020
| @@ -32,7 +44,7 @@ export default async function switchToFrame ({ id }) { | |||
| * `page` has `frames` method while `frame` has `childFrames` method | |||
| */ | |||
| let getFrames = page.frames || page.childFrames | |||
| const childFrames = await getFrames() | |||
| const childFrames = await getFrames.apply(page) | |||
There was a problem hiding this comment.
The method doesn't take arguments. @takeya0x86 is correct here we call the method without its scope.
|
Build is currently broken due to #5369 .. let's wait until it gets merged so we can rebase. Thank you @takeya0x86 for providing a fix! |
|
I will go ahead and merge this so I can include it in the next release. |
christian-bromann
added
backport-requested
christian-bromann
pushed a commit
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fixes #5345
Add tests
Fix codes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers