Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requestedCapabilities better accessible #5351

Merged
merged 7 commits into from May 5, 2020

Conversation

christian-bromann
Copy link
Member

Proposed changes

A lot of user have asked how to access their original capabilities from the browser object. So far we have given advise to access it via an un-documented way using: browser.options.requestedCapabilities.w3cCaps which we used internally to allow reloading the session with the same set of caps. This PR improves the access to this object by just calling browser.requestedCapabilities.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 4, 2020
@christian-bromann christian-bromann requested a review from a team May 4, 2020 13:07
@mgrybyk
Copy link
Member

mgrybyk commented May 5, 2020

@christian-bromann browser.options.capabilities is the same as browser.requestedCapabilities ?

image

@christian-bromann
Copy link
Member Author

browser.options.capabilities is the same as browser.requestedCapabilities ?

Yes. browser.options is the config object that you used to create the WebdriverIO session.

Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you think we need to have both options.capabilities and requestedCapabilities?

Copy link
Member

@mgrybyk mgrybyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway as far as we can tackle questions above separately if needed.

Thank you

@christian-bromann christian-bromann merged commit bcef250 into master May 5, 2020
@christian-bromann christian-bromann deleted the cb-requestedCapabilities branch May 5, 2020 14:34
christian-bromann added a commit that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants