Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for devtools service #5361

Merged
merged 9 commits into from May 5, 2020
Merged

Add types for devtools service #5361

merged 9 commits into from May 5, 2020

Conversation

pako88
Copy link
Member

@pako88 pako88 commented May 5, 2020

Proposed changes

Add types and tests for devtools service

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

christian-bromann
christian-bromann requested changes May 5, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

tests/typings/copy.js Outdated Show resolved Hide resolved
christian-bromann
christian-bromann approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic 👏 thank you so much!

@christian-bromann christian-bromann mentioned this pull request May 5, 2020
Closed
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label May 5, 2020
@christian-bromann christian-bromann merged commit 9fdc50a into webdriverio:master May 5, 2020
@pako88 pako88 deleted the add-types-for-devtools-service branch May 5, 2020 15:51
@christian-bromann christian-bromann added backport-requested PRs with this label are considered to be applied to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pako88 @christian-bromann