Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript configuration for jasmine #5397

Merged
merged 1 commit into from May 15, 2020

Conversation

woolter
Copy link
Contributor

@woolter woolter commented May 14, 2020

'tsconfig-paths/register' was added to Jasmine configuration

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

I saw a couple of questions related with this in gitter channel and I had the same problem till I read a comment from @mgrybyk

Reviewers: @webdriverio/project-committers

'tsconfig-paths/register' was added to Jasmine configuration
@christian-bromann
Copy link
Member

@woolter just to be clear: is this tsconfig-paths/register actually needed or just a nice addition. I am sure there are a variety of different ways to setup TypeScript, the docs should provide a super minimal example.

@woolter
Copy link
Contributor Author

woolter commented May 15, 2020

@christian-bromann to be honest was the only way that I found to make work when you use paths in tsconfig.json.
On the other hand, in the examples for cucumber and mocha we have tsconfig-paths/register

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me then 👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 15, 2020
@christian-bromann christian-bromann merged commit 604ba2b into webdriverio:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants