Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class syntax in CustomServices.md #5402

Merged
merged 1 commit into from May 15, 2020
Merged

Fix class syntax in CustomServices.md #5402

merged 1 commit into from May 15, 2020

Conversation

pmdartus
Copy link
Member

Proposed changes

This PR fixes a JavaScript syntax error in custom services documentation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

None

Reviewers: @webdriverio/project-committers

@jsf-clabot
Copy link

jsf-clabot commented May 15, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

christian-bromann
christian-bromann approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@christian-bromann
Copy link
Member

@pmdartus would you mind to sign the CLA so we can merge this PR?

@pmdartus
Copy link
Member Author

Done @christian-bromann
Thanks for the quick response.

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 15, 2020
@christian-bromann christian-bromann merged commit 6422934 into webdriverio:master May 15, 2020
@pmdartus pmdartus deleted the patch-1 branch May 15, 2020 14:55
@christian-bromann christian-bromann added backport-requested PRs with this label are considered to be applied to the last maintained version backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels May 25, 2020
christian-bromann pushed a commit that referenced this pull request May 25, 2020
@pmdartus @christian-bromann
Fix class syntax in CustomServices.md (#5402)
6658b3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmdartus @jsf-clabot @christian-bromann