Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update TypeScript.md #5403

Merged
merged 1 commit into from May 15, 2020

Conversation

osmolyar
Copy link
Contributor

Proposed changes

Update Docs: TypeScript.md section on config file for using typed wdio.config file t

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] Documentation update

Checklist

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

This was necessary because otherwise index.d.ts or other standalone type definition files don't get recognized by the ts-node compiler if a typed config is used.

Reviewers: @webdriverio/project-committers

@jsf-clabot
Copy link

jsf-clabot commented May 15, 2020

CLA assistant check
All committers have signed the CLA.

@erwinheitzman erwinheitzman merged commit 0b25283 into webdriverio:master May 15, 2020
@osmolyar osmolyar deleted the update_typescript_docs branch May 15, 2020 21:12
@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label May 15, 2020
@osmolyar osmolyar restored the update_typescript_docs branch May 18, 2020 13:49
@osmolyar osmolyar deleted the update_typescript_docs branch May 18, 2020 13:55
@christian-bromann christian-bromann added backport-requested PRs with this label are considered to be applied to the last maintained version backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels May 25, 2020
christian-bromann pushed a commit that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants