Fix overwriting compiled manifest #890
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch I was given pushed to |
|
@vwheezy the variable type should still be const. You can push to consts. 
You'll notice the linter fails now because of this |
|
Oops. Sorry about that. I need some best practice tips here: should I just commit a fix or rewrite history? |
|
You can just commit again. I can squash and merge when it's all done |
|
@tm1000 Committed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 628 in webpack-webextension-plugin
The CopyPlugin copies over the original
manifest.json, overwriting the compiled version on all recompiles in dev/watch mode.