5.40.0 Fixes - Batch 2 (themes/src)
#4124
Conversation
|
/cypress |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
| @@ -50,7 +50,7 @@ | |||
| "typescript": "4.7.4" | |||
| }, | |||
| "workspaces": { | |||
| "packages": ["apps/admin", "apps/website", "apps/api/graphql", "extensions/theme", "packages/*"] | |||
| "packages": ["apps/admin", "apps/website", "apps/api/graphql", "packages/*", "extensions/theme"] | |||
There was a problem hiding this comment.
It should be extensions/*, just like packages/*, and then you never need to modify these rules again.
There was a problem hiding this comment.
The thing is, users can also create extensions in e.g. extensions/fm/api/xyz folder.
There was a problem hiding this comment.
If you think everyone will be using scaffolds, then probably this is ok.
There was a problem hiding this comment.
Yes, every extension article we'll have will essentially start with scaffold run. Examples:
https://docs-webiny-com-git-release-5400-webiny.vercel.app/docs/file-manager/extending/customize-file-preview
https://docs-webiny-com-git-release-5400-webiny.vercel.app/docs/file-manager/extending/customize-file-actions
Tip: the Getting Started section is actually generated via a React component.
|
Went through this changes with @Pavel910. |
Changes
This PR moves all of the code in the
extensions/themefolder toextensions/theme/src. This was made for consistency (the new scaffolds also follow this folder structure).With that, one additional change we did here is the import of the
global.scssfile. Previously, the file was directly imported from Admin/Website React apps, but now, they are imported within the thethemepackage's code.How Has This Been Tested?
Manually.
Documentation
Changelog.