Lending system frontend #4219
Lending system frontend #4219
Conversation
ABA-613 Lending system
Backup has requested a lending system, as Abakus has a lot of objects that could be lent out to Ababeads if we just had a good system for it. Arrkom also wants this system to make it easier to administrate Soundboks and grill lending. |
eikhr
force-pushed
the
lending-system
branch
2 times, most recently
from
5a81cca
to
96b9d4f
Compare
|
Haha, It's very WIP. How do you think we should do the colors in the calendar? I'm not sure if css variables work there, but now that I think of it I don't believe we tried🤔 |
ivarnakken
added
do-not-merge/WIP
ivarnakken
added
priority:high
app/reducers/index.ts
Outdated
| export const lendableObjectSchema = new schema.Entity(EntityType.LendableObjects, { | ||
| responsibleGroups: [groupSchema], | ||
| }); | ||
| export const lendingRequestSchema = new schema.Entity(EntityType.LendingRequests); |
There was a problem hiding this comment.
normalize the nested lendableObject in lendingRequest?
There was a problem hiding this comment.
Do you mean to add a lendableObject field to the schema like this:
| export const lendingRequestSchema = new schema.Entity(EntityType.LendingRequests); | |
| export const lendingRequestSchema = new schema.Entity(EntityType.LendingRequests, { | |
| lendableObject: lendableObjectSchema, | |
| }); |
| let url = `/lending/request/${request.id}`; | ||
| if (isAdmin) { | ||
| url += '/admin'; | ||
| } | ||
| return ( | ||
| <Link to={url} className={styles.requestItem} key={request.id}> |
|
This system does not seem to support contracts, like I know Arrkom uses when lending stuff out. I don't think we need to upload contracts for each object, but there should be some responsibility acknowledgement info and button or something. Talk to Arrkom about how they would like this |
I think the plan was to add some support for contracts, but we can consider a different approach, like you suggest. For now we want to finalize the current functionality and get it merged to master (but disable link to this page) and then iterate on further funtionality like this later in order to avoid to much rebasing and try and get a mvp working. |
| import type { Params } from 'react-router-dom'; | ||
|
|
||
| const LendableObjectAdminDetail = () => { | ||
| const { lendableObjectId } = useParams<Params>(); |
There was a problem hiding this comment.
@Bestem0r I see that a lot of comments here have been set as resolved without any changes. Have you pushed everything?
ivarnakken
added
approved
Description
Result
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ABA-613