Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ButtonGroup component #4701

Merged
merged 2 commits into from
May 14, 2024
Merged

Add ButtonGroup component #4701

merged 2 commits into from
May 14, 2024

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented May 13, 2024

Description

I figured we should have a component to ensure consistent spacing in groups of buttons.

Result

Not much has changed, as I used the same spacing that was normally used already. But I changed a few things I was annoyed by, see the table below.

I also re-added this #4156 fix which seems to have been lost during react-router refactoring.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Description Before After
Changed the SoMe links in "Om Abakus" to all be link-buttons instead of a mix of normal links and link-buttons. Screenshot 2024-05-14 at 00 40 56 Screenshot 2024-05-14 at 00 42 18
Changed layout of photo-consent buttons. Screenshot 2024-05-14 at 00 44 47 Screenshot 2024-05-14 at 00 43 19

Testing

  • I have thoroughly tested my changes.

I looked at them.

@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 8:35am

@github-actions github-actions bot added the review-needed Pull requests that need review label May 13, 2024
@eikhr eikhr requested review from ivarnakken, ShaileshS1702 and a team May 13, 2024 16:47
@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features technical-debt Pull requests that reduces technical debt labels May 13, 2024
falbru
falbru approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

ivarnakken
ivarnakken approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like!

packages/lego-bricks/src/components/Button/ButtonGroup.tsx Outdated Show resolved Hide resolved
packages/lego-bricks/src/components/Button/ButtonGroup.tsx Show resolved Hide resolved
@eikhr eikhr enabled auto-merge May 14, 2024 08:34
@eikhr eikhr merged commit 34d4984 into master May 14, 2024
6 checks passed
@eikhr eikhr deleted the button-group-component branch May 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbru falbru falbru approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@ShaileshS1702 ShaileshS1702 Awaiting requested review from ShaileshS1702

Assignees
No one assigned
Labels
enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review technical-debt Pull requests that reduces technical debt
Projects
None yet
Milestone
No milestone
3 participants
@eikhr @falbru @ivarnakken