Erf operator Implementation #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AmineDiro! Sorry, only just got around to having a look at this. Your PR looks good! I would suggest however placing the Erf calculation itself in the activation templates (here) - otherwise we will end up with many different templates for similar functions. |
|
Hi @pixelspark , No worries, thanks for taking the time to review this PR! |
|
@pixelspark could you please merge this PR? |
|
Sorry, took a while, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is implementation on the approximate Erf operator. This operator is needed for models using the GELU activation function for example the majority of transformer models.
Onnx supports Gelu directly but it is starting from opset 20 so I think that this operator is useful for now.
Happy to make changes based on your suggestions !