Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repeatable directives #608

Closed
spawnia opened this issue Jan 11, 2020 · 4 comments · Fixed by #643
Closed

Support repeatable directives #608

spawnia opened this issue Jan 11, 2020 · 4 comments · Fixed by #643

Comments

@spawnia
Copy link
Collaborator

spawnia commented Jan 11, 2020

The specification recently included a new keyword repeatable that allows specifying directives that may be defined multiple times.

graphql/graphql-spec#472

Reading multiple directives already works fine, so that part should not be too hard. We will have to add support for the new keyword and adapt the validation steps to handle it.

Partial support was already added to the reference implementation: graphql/graphql-js#1965

Full support is underway, too: graphql/graphql-js#1541

@spawnia spawnia changed the title Support repeatable directive Support repeatable directives Jan 11, 2020
@spawnia
Copy link
Collaborator Author

spawnia commented Jun 8, 2020

@vladar do you have plans for a next release where this can land?

Asking because I am planning a major version jump in Lighthouse and want to upgrade graphql-php with it.

@vladar
Copy link
Member

vladar commented Jun 8, 2020

Let's set a deadline, otherwise, I will keep postponing it 😉 Let's publish 14.0 on the 21st of June (still need several things to do before publishing).

@spawnia
Copy link
Collaborator Author

spawnia commented Jun 8, 2020

That's going to be a nice birthday present for me 🍰 Cool!

Let me know what i can do to help, i would love to get more involved with the project.

@vladar
Copy link
Member

vladar commented Jun 8, 2020

Oh, that's a good match :)

Thanks for proposing help! Added you as a maintainer. I am definitely happy to have more maintainers, especially people like you committed to GraphQL community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants