Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support repeatable directives #643

Merged
merged 9 commits into from Jun 8, 2020
Merged

Support repeatable directives #643

merged 9 commits into from Jun 8, 2020

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Apr 13, 2020

@spawnia spawnia marked this pull request as ready for review April 14, 2020 19:58
@spawnia
Copy link
Collaborator Author

spawnia commented Apr 27, 2020

@simPod have you had a chance to review this PR yet?

@simPod
Copy link
Collaborator

simPod commented Apr 27, 2020

@spawnia I'll take a look but definitely don't feel competent to merge this after on my own, @vladar will have to do it :)

spawnia and others added 2 commits April 27, 2020 14:28
@spawnia @simPod
Make DirectiveTest.php final
4963d01 
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
@spawnia
Merge branch 'master' into support-repeatable-directives
f775561 
# Conflicts:
#	phpstan-baseline.neon
#	src/Type/Introspection.php
#	src/Utils/SchemaPrinter.php
#	src/Validator/Rules/UniqueDirectivesPerLocation.php
@coveralls
Copy link

coveralls commented Jun 8, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 86.148% when pulling fda2f80 on spawnia:support-repeatable-directives into 3887d8f on webonyx:master.

@vladar
Copy link
Member

vladar commented Jun 8, 2020

@spawnia Is it ready for merging? (just to make sure)

@spawnia
Copy link
Collaborator Author

spawnia commented Jun 8, 2020

@spawnia Is it ready for merging? (just to make sure)

Yes. I just checked if there are breaking changes we might want to mention, haven't found any.

vladar
vladar approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks solid, so let's merge it! 🚢

@vladar vladar merged commit 91b55bb into webonyx:master Jun 8, 2020
@spawnia spawnia deleted the support-repeatable-directives branch June 8, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simPod simPod simPod left review comments

@shmax shmax shmax left review comments

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support repeatable directives
5 participants
@spawnia @simPod @coveralls @vladar @shmax