Prevent chunking out when not in production environment

[jalooc]

Due to HMR problems with on-demand chunks, I figured it would be nice if the loader loaded the chunks synchronously when in dev environment and as so far in prod. And that's what this commit does.

Other ideas: I was also wondering about adding some additional flag to force async loading in development, but eventually opted-out. Alternatively, sync loading in development could be made an optional (instead of default) behavior. If you find some of the modifications useful, I'd be happy to alter the merge request to suit more needs.

[jsf-clabot]

All committers have signed the CLA.

[michael-ciniawsky]

@jalooc I'm not regularly using this loader so I need to get other eyes on this aswell 😛

[michael-ciniawsky]

I think it's better to introduce an option here, NODE_ENV === 'production' is common, but no real standard

[jalooc]

I was also wandering about adding an option (just another env var) forcing synchronous load, which could be potentially useful in static page rendering e.g. for ssr or bots. Do you think it's a good idea?

[michael-ciniawsky]

@jalooc If you are not enterily pissed of in case we maybe need to revert a few things afterwards, then please go ahead and we will see if it is something we should add or not 😛

I was also wandering about adding an option (just another env var)

Just and option (query), eg require(bundle-loader?sync&name=[name]!./file.bundle.js)
Could you also try if webpacj 2 snytax and setting the loader up in webpack.config.js basically works ? 🙃

entry.js

import bundle from './name.bundle.js'

webpack.config.js

{
   test: /\.bundle\.js$/,
   use: { loader: 'bundle-loader', options: { name: '[name]' } }
},
{
   test: /\bundle\.async\.js$/,
   use: { loader: 'bundle-loader', options: { lazy: true, name: '[name]' } }
}

etc 😛

Maybe if we add a sync option, we should rename lazy => async and cut a major release together with #48 what do you think 🙃 ?

[joshwiens]

@jalooc @michael-ciniawsky - See #51 (comment)

[michael-ciniawsky]

kk, so sync doesn't make any sense at all ? I was wondering about it, but not 💯 since i'm not using this loader extensively. If so we better close the PR :)

[jalooc]

@michael-ciniawsky I'm not sure if I fully understand your point. The suggested in this PR ability for skipping chunking-out (I called it sync loading before, but maybe it was confusing) is just for development purposes, so files naming convention wouldn't be right for this application. I also don't think it's related with #51.