-
-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
===================================
Coverage 0% 0%
===================================
Files 2 2
Lines 80 85 +5
Branches 12 12
===================================
- Misses 68 74 +6
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
const options = loaderUtils.getOptions(this) || {}; | ||
const cacheDirectory = options.cacheDirectory || path.resolve('.cache-loader'); | ||
const loaderOptions = loaderUtils.getOptions(this) || {}; | ||
const defaultOptions = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be the same for every call to pitch()
so it would make sense to define it outside the fn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@STRML done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - doesn't appear pushed though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evilebottnawi Can't the whole defaultOptions
block be moved for some reason ? 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-ciniawsky oh, yep, your are right
What's missing here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adressing @STRML comment maybe a good idea :)
b6932ab
to
b47a98b
Compare
Removing the WIP seems to be good to go ? |
src/index.js
Outdated
const callback = this.async(); | ||
const hash = digest(remainingRequest); | ||
const hash = digest(JSON.stringify({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to:
const hash = digest(remainingRequest + cacheIdentifier);
Faster. Options don't need to be included.
b47a98b
to
4fa74df
Compare
Thanks |
Steps:
cache-loader
updated.cache-loader
options changed.As sokra says:
We can just add this in README.
As sokra says:
Partial fixed: #3