Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate global options too #437

Closed
wants to merge 1 commit into from

Conversation

akx
Copy link
Contributor

@akx akx commented Mar 9, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

I noticed #419 added validation for the patterns array, but the global options (which are touched by e.g. #435) aren't validated. (I may or may not have banged my head against the wall there.)

The documentation was also updated to reflect the fact that one can actually pass in Minimatch settings objects for ignore too.

Breaking Changes

This may break some downstream software misusing the options object.

Additional Info

"Test update" is not checked, because tests don't pass in naughty options.

src/options.json Outdated Show resolved Hide resolved
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note

@alexander-akait
Copy link
Member

Can you update jest to avoid npm problem too?

@akx
Copy link
Contributor Author

akx commented Mar 10, 2020

Can you update jest to avoid npm problem too?

@evilebottnawi No, that was discussed in the comment in #438 – updating Jest (via npm audit --fix) breaks compatibility with Node 6 and Node 8 since it begins using native async/await. Dropping Node 6 and Node 8 is discussed in #412.

@alexander-akait
Copy link
Member

Thanks for the PR, we will remove global options in the next major release, because we already remove logLevel (we use built-in webpack logger you can setup level using webpack config) and copyUnmodifed options (it was bad design we need persist assets between builds), so I am closing this PR, I start to removing global options support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants