Clarify what context does. Improve phrasing
#736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous summary of `context` ("A path that determines how to interpret the from path") was vague, and didn't really explain what context does.
"*How* does context determine how to interpret the `from` path?" I wondered. It wasn't until looking through the examples, over a day after trying to figure this out, that I had a clue.
I hope my edit makes the role of `context` clearer, so that others won't have to suffer as I did.
alexander-akait
previously approved these changes
Apr 8, 2023
|
Can you fix linting? |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 90.17% 90.17%
=======================================
Files 2 2
Lines 397 397
Branches 119 119
=======================================
Hits 358 358
Misses 38 38
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Done |
alexander-akait
merged commit 82f3bc7
into
webpack-contrib:master
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous summary of
context("A path that determines how to interpret the from path") was vague, and didn't really explain what context does."How does context determine how to interpret the
frompath?" I wondered. It wasn't until looking through the examples, over a day after trying to figure this out, that I had a clue.I hope my edit makes the role of
contextclearer, so that others won't have to suffer as I did.This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info