fix: add file from an error to file dependencies

webpack-contrib · Apr 24, 2020 · 841423f · 841423f
1 parent b04641c
commit 841423f
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -150,6 +150,12 @@ export default function loader(content, map, meta) {
       return callback(null, `${importCode}${moduleCode}${exportCode}`);
     })
     .catch((error) => {
+      if (error.file) {
+        console.log(error.file);
+
+        this.addDependency(error.file);
+      }
+
       callback(
         error.name === 'CssSyntaxError' ? new CssSyntaxError(error) : error
       );

diff --git a/test/fixtures/invalid.css → test/fixtures/error.css b/test/fixtures/invalid.css → test/fixtures/error.css
diff --git a/test/fixtures/invalid.js → test/fixtures/error.js b/test/fixtures/invalid.js → test/fixtures/error.js
@@ -1,4 +1,4 @@
-import css from './invalid.css';
+import css from './error.css';
 
 __export__ = css;
 

diff --git a/test/helpers/ast-loader.js b/test/helpers/ast-loader.js
@@ -11,7 +11,10 @@ export default function astLoader(content) {
   const { spy = jest.fn() } = this.query;
 
   postcss([postcssPresetEnv({ stage: 0 })])
-    .process(content)
+    .process(content, {
+      // eslint-disable-next-line no-undefined
+      from: undefined,
+    })
     .then(({ css, map, root, messages }) => {
       const ast = {
         type: 'postcss',

diff --git a/test/loader.test.js b/test/loader.test.js
@@ -123,9 +123,14 @@ describe('loader', () => {
   });
 
   it('should throw error on invalid css syntax', async () => {
-    const compiler = getCompiler('./invalid.js', {});
+    const compiler = getCompiler('./error.js', {});
     const stats = await compile(compiler);
 
+    expect(
+      stats.compilation.fileDependencies.has(
+        path.resolve('./test/fixtures/error.css')
+      )
+    ).toBe(true);
     expect(getWarnings(stats)).toMatchSnapshot('warnings');
     expect(getErrors(stats)).toMatchSnapshot('errors');
   });