Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not duplicate css on composes #1040

Merged
merged 1 commit into from Jan 10, 2020
Merged

fix: do not duplicate css on composes #1040

merged 1 commit into from Jan 10, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1037

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #1040 into master will increase coverage by 1.29%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   96.84%   98.14%   +1.29%     
==========================================
  Files          10       10              
  Lines         476      484       +8     
  Branches      147      150       +3     
==========================================
+ Hits          461      475      +14     
+ Misses         12        8       -4     
+ Partials        3        1       -2
Impacted Files Coverage Δ
src/utils.js 98.96% <100%> (ø) ⬆️
src/runtime/api.js 85.71% <44.44%> (+21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9f47b...777d876. Read the comment docs.

@jquense
Copy link
Contributor

jquense commented Jan 10, 2020

thanks for all the hard work @evilebottnawi !

@alexander-akait
Copy link
Member Author

@jquense I will ping you when I done release, check if everything is well fixed

@@ -22,15 +22,33 @@ module.exports = function(useSourceMap) {

// import a list of modules into the list
// eslint-disable-next-line func-names
list.i = function(modules, mediaQuery) {
list.i = function(modules, mediaQuery, dedupe) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that possible to have it to be true by default?
e.g.
function(modules, mediaQuery, dedupe = true)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Composes" duplicating css (again)
3 participants