fix: deduplicate css module for @import #1044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 10 10
Lines 484 484
Branches 150 149 -1
=======================================
Hits 475 475
Misses 8 8
Partials 1 1
Continue to review full report at Codecov.
|
fa93hws
commented
Jan 22, 2020
Comment on lines
-619
to
-730
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "screen and (orientation:landscape)", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "screen and (orientation: landscape)", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "screen and (orientation:landscape)", | ||
| ], | ||
| Array [ | ||
| "../../src/index.js?[ident]!./import/test.css", | ||
| ".test { | ||
| a: a; | ||
| } | ||
| ", | ||
| "screen and (orientation:landscape)", | ||
| ], |
fa93hws
commented
Jan 22, 2020
Comment on lines
625
to
+635
| Array [ | ||
| "./import/import.css", | ||
| "@import url(http://example.com/style.css);", | ||
| "", | ||
| true, | ||
| ], | ||
| Array [ | ||
| "./import/import.css", | ||
| "@import url(http://example.com/style.css);", | ||
| "", | ||
| true, |
There was a problem hiding this comment.
Do they need to be de-duplicated? It's the url case.
If the de-duplication is necessary in all cases, probably we should change the runtime #1040 (comment).
|
|
This was referenced Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
composesis fixed in https://github.com/webpack-contrib/css-loader/pull/1040/files#diff-2b4ca49d4bb0a774c4d4c1672d7aa781R329 but@importisn't.The use-case can be refereed to the added test case.
"source" which imports "black" which composes "color" and;
"source" which imports "swhite" which composes "color".
On this case, the "color" module gets duplicated.
Breaking Changes
No
Additional Info
N/A