fix: respected style field from package.json #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 97.29% 96.77% -0.53%
==========================================
Files 10 10
Lines 481 527 +46
Branches 162 174 +12
==========================================
+ Hits 468 510 +42
- Misses 12 16 +4
Partials 1 1
Continue to review full report at Codecov.
|
cap-Bernardito
force-pushed
the
issue-683
branch
2 times, most recently
from
bbea9c7
to
c2947ba
Compare
| mainFiles: ['index', '...'], | ||
| extensions: ['.css'], | ||
| restrictions: [/\.css$/i], | ||
| }); |
There was a problem hiding this comment.
conditionNames: ['style'],
|
@cap-Bernardito, question for you: did this ever work? Was the |
|
@arshaw And yes and no, before this commit you need to setup the |
andersk
reviewed
Aug 13, 2020
| mainFields: ['css', 'style', 'main', '...'], | ||
| mainFiles: ['index', '...'], | ||
| extensions: ['.css'], | ||
| restrictions: [/\.css$/i], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #683
Breaking Changes
No
Additional Info
No