Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/loader): correctly wrap url's containing anchors #757

Closed
wants to merge 2 commits into from

Conversation

rustjson
Copy link

@rustjson rustjson commented Aug 17, 2018

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
YES

If relevant, did you update the README?
no need

Summary

@font-face {
  font-family: 'Jason Web';
  src: url("jason-font.eot");
  src: url("jason-font.eot?#iefix") format("embedded-opentype");
}

is compiled to

@font-face {
  font-family: 'Jason Web';
  src: url("jason-font.eot");
  src: url("jason-font.eot"?#iefix) format("embedded-opentype");
}

In the url: "jason-font.eot"?#iefix, the last quote should before the brace.

Does this PR introduce a breaking change?
NO

Other information

@jsf-clabot
Copy link

jsf-clabot commented Aug 17, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title Fix the quote when url contains anchor fix(lib/loader): corretly wrap url's containing anchors Aug 17, 2018
@michael-ciniawsky michael-ciniawsky added this to the 1.0.1 milestone Aug 17, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustjason Thx

@michael-ciniawsky michael-ciniawsky changed the title fix(lib/loader): corretly wrap url's containing anchors fix(lib/loader): correctly wrap url's containing anchors Aug 17, 2018
@rustjson
Copy link
Author

rustjson commented Sep 2, 2018

ping @michael-ciniawsky , any timeline to merge this?

@alexander-akait
Copy link
Member

Sorry for delay solved in #803, will be shipped in near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants